Add a timelimit context handler, eye towards BANE deadlocks #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #200 +/- ##
==========================================
+ Coverage 60.48% 60.53% +0.05%
==========================================
Files 35 35
Lines 6154 6190 +36
==========================================
+ Hits 3722 3747 +25
- Misses 2432 2443 +11 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been noted that under some strange set of circumstances that BANE can get into a deadlock. There has been some issue raised here for a while (#187 ).
This is a heavy handed attempt to fix it. It establishes a timelimit on the execution of the bane and aegean tasks. Nominally this is set to 45 minutes.
Really this should be fixed where it is an actually problem. Something in BANE, sharedmemory and heavy loads is causing something to go wrong. But for the moment this will do.